-
Notifications
You must be signed in to change notification settings - Fork 383
feat: texture management #2601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pandinocoder
merged 60 commits into
AscensionGameDev:main
from
pandinocoder:feat-texture-management
Feb 20, 2025
Merged
feat: texture management #2601
pandinocoder
merged 60 commits into
AscensionGameDev:main
from
pandinocoder:feat-texture-management
Feb 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng it down more and more)
…bunch of thrashing that needs to be fixed
…l haven't figured out how to stop the row height thrashing
…the game on close
…sure why this code still existed since if the size changes it was already being rebuilt
…t (~2%) but this is an extremely hot code path
…is empty... it saves so much time... from 1.065us/call to 0.215us/call, and this is a call that is getting hit around 37k times per second just on the main menu when locked to 30fps... unlimited FPS on my machine resulted in 357k hits per second... at 30fps it was a difference between 39.4ms vs 8ms total, and uncapped it was 380ms vs 76.7ms note: more performance can be saved here if we can figure out a way to track the emptiness of the thread queues in the tree without adding back that pesky parent BS in the TQ that destroyed performance potential 3:45am braindead solution for this is to pass a reference to a counter or boolean in the node that the TQ has access to and this can be propagated up the tree or something -- that or maybe lazily creating the thread queue, or somehow having a flat global threadqueue lookup (though i think this has the potential to be non-performant in comparison)
…ints can be set properly
…elected resolution
540d09b to
561ccfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final prerequisite for texture preloading